Skip to content

[ PUBLIC-API ] Added Start Workspace Route for Gitpod Public API #17851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

henit-chobisa
Copy link
Contributor

Description

The current pull request aims to add a new route to the experimental public api for starting user's existing workspaces while returning a unary response in form of json consisting workspaceID and instanceID by pre-existing definitions in the workspaces.proto file in the public api.

Related Issue(s)

Adds up to #7900

How to test

  • Unit tests

Release Notes

NONE

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@henit-chobisa
Copy link
Contributor Author

Hey @gtsiolis, me and @Palanikannan1437 have been trying to wrap our heads around the public-api, we tried to add a StartWorkspace method to the public api, can you please have a look once. 🙏🏼
Thanks 💛

@Palanikannan1437
Copy link
Contributor

Hey there @gtsiolis! It'd be really helpful for us to iterate upon it further if you could please spin up a preview environment once 🚀, thanks 🙌

@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 6, 2023

Hey @henit-chobisa @Palanikannan1437, I've forwarded this internally to the team for visibility. 🏓

@henit-chobisa
Copy link
Contributor Author

Hey @henit-chobisa @Palanikannan1437, I've forwarded this internally to the team for visibility. 🏓

Thank you so much @gtsiolis

@easyCZ
Copy link
Member

easyCZ commented Jun 14, 2023

Thanks for the PR. Unfortunately at the moment we're not in a position to progress the Public API with outside contributions. This is primarily due to capacity. The implementation of those APIs is really only the smallest part in overall time/effort commitment as it subsequently requires operational investment (monitoring, maintenance, documentation) which we right now are not in a position to commit.

We hope to be able to to get back to this around Q4.

@easyCZ easyCZ closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants