Skip to content

gp ssh #17998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 22, 2023
Merged

gp ssh #17998

merged 10 commits into from
Jun 22, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jun 21, 2023 •
edited
Loading

Description

Adds a gp ssh command for printing the SSH command used to access the workspace. This relies on having SSH keys setup.

Related Issue(s)

Fixes #11415

How to test

go run /workspace/gitpod/components/gitpod-cli ssh

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@filiptronicek
Copy link
Member Author

filiptronicek commented Jun 21, 2023 •
edited
Loading

What's left to do is to resolve this issue with getting the owner token:

Dismissed because of security considerations

gitpod /workspace/gitpod/components/gitpod-cli (ft/gp-ssh) $ go run . ssh --access-key
failed getting token from supervisor: rpc error: code = NotFound desc = no token available
exit status 1

@roboquat roboquat added size/M and removed size/L labels Jun 21, 2023
@filiptronicek filiptronicek marked this pull request as ready for review June 21, 2023 09:48
@filiptronicek filiptronicek requested a review from a team June 21, 2023 09:48
@filiptronicek filiptronicek mentioned this pull request Jun 21, 2023
Closed
@filiptronicek filiptronicek self-assigned this Jun 21, 2023
akosyakov
akosyakov approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible, i did not try

@filiptronicek
Copy link
Member Author

Let's :shipit:

/unhold

@roboquat roboquat merged commit 673ac4d into main Jun 22, 2023
@roboquat roboquat deleted the ft/gp-ssh branch June 22, 2023 08:30
AlexTugarev pushed a commit that referenced this pull request Jun 22, 2023
@filiptronicek @AlexTugarev
gp ssh (#17998)
40ed1e8 
* Add `gp ssh`

* Implement non-working owner token retrieval

* `--access-token`

* Remove access token method

* update help text

* Format errors

* Enhance help command

* Remove unused import

* Unnecessary variable

* Add todo
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees

@filiptronicek filiptronicek

Labels
component: gp cli deployed: IDE IDE change is running in production deployed Change is completely running in production size/M team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show ssh connection command from gp
3 participants
@filiptronicek @akosyakov @roboquat