Skip to content

Fix user env variables for GitLab repos in subgroups #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

corneliusludmann
Copy link
Contributor

This allows projects like 'foo/bar/baz' where 'foo/bar' is the owner and 'baz' the user.

Assuming this repo: https://gitlab.com/gp-test-group/gp-test-subgroup/gp-test-project-in-subgroup

owner: gp-test-group/gp-test-subgroup
repo:  gp-test-project-in-subgroup

These repo patterns work:

*/*
gp-test-group/gp-test-subgroup/gp-test-project-in-subgroup
gp-test-group/gp-test-subgroup/*
*/gp-test-project-in-subgroup

These do not work (for the given project):

gp-test-group/*
gp-test-group/*/gp-test-project-in-subgroup
*/gp-test-subgroup/gp-test-project-in-subgroup

How to test

Corresponding issue

Issue: #1358

This allows projects like 'foo/bar/baz' where 'foo/bar' is the owner and 'baz' the user.
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (Also works well)

@corneliusludmann corneliusludmann merged commit 39ad4b4 into master Sep 3, 2020
@corneliusludmann corneliusludmann deleted the corneliusludmann/environment-variables-1358 branch September 3, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants