Skip to content

Move Gitpod icon away from the navigation #18213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jul 10, 2023

Description

Experiment with moving the Gitpod icon away from the navigation to avoid clashing with the organization icon.

For more context, we also hide the Gitpod icon on smaller viewports, see #16618.

See relevant discussion (internal). Cc @jankeromnes @svenefftinge @mbrevoort

BEFORE AFTER
Frame 1637 Frame 1638

How to test

  1. Log in and see how the Gitpod logo is no longer clashing with the organization logo in the navigation.

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@gtsiolis gtsiolis force-pushed the gt/move-gitpod-icon branch from 471b099 to 009a45c Compare July 10, 2023 11:34
@roboquat roboquat added size/XS and removed size/S labels Jul 10, 2023
@gtsiolis
Copy link
Contributor Author

Ready-For-Review 🏓

Feedback is welcome!

@gtsiolis gtsiolis marked this pull request as ready for review July 10, 2023 11:47
@gtsiolis gtsiolis requested a review from a team July 10, 2023 11:47
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 10, 2023
@gtsiolis
Copy link
Contributor Author

Thanks for taking a look, @easyCZ. 🌮

@gtsiolis
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 7629c76 into main Jul 10, 2023
@roboquat roboquat deleted the gt/move-gitpod-icon branch July 10, 2023 13:22
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants