Skip to content

[supervisor] improve docker activation #18284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jul 14, 2023

This reverts #18236

Description

This PR add back #18143 and add a logic for waiting content init.

Related Issue(s)

Fix #18091
Fix IDE-205

How to test

  1. start a workspace in preview env
  2. follow How to test section in [supervisor] improve docker activation #18143, but do it in preview env workspace
  3. stop workspace and restart workspace for many times, it should be ok with no error.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@iQQBot
Copy link
Contributor Author

iQQBot commented Jul 17, 2023

tested with restart workspace, it looks good

@iQQBot iQQBot marked this pull request as ready for review July 17, 2023 08:59
@iQQBot iQQBot requested a review from a team July 17, 2023 08:59
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test, but a change makes sense 🤞

@roboquat roboquat merged commit 9bb400b into main Jul 17, 2023
@roboquat roboquat deleted the revert-18236-ide/revert-supervisor-docker-changes branch July 17, 2023 09:11
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 17, 2023
kylos101 added a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production size/XL team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gp validate: container workspace completed; containers of a workspace pod are not supposed to do that
3 participants