Skip to content

Revert "[ws-daemon] Change readiness behavior to wait for registry-facade" #19668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Apr 25, 2024

Reverts #19661

@iQQBot iQQBot requested a review from a team as a code owner April 25, 2024 15:00
@roboquat roboquat merged commit 8838eb9 into main Apr 25, 2024
17 checks passed
@roboquat roboquat deleted the revert-19661-aledbf/ws-daemon-check branch April 25, 2024 15:01
@aledbf
Copy link
Member

aledbf commented Apr 25, 2024

@iQQBot why the revert? We tested this on CI and dogfood

@iQQBot
Copy link
Contributor Author

iQQBot commented Apr 25, 2024

@aledbf We need to immediately create a new release to unblock the current release due an incident.
This PR currently appears to have certain risks and does not meet the requirement of staying in dogfood for 24 hours, so we first reverted this PR and then created a release.

I will reapply this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants