Skip to content

chore: fix inconsistent function name in comment #21026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

chore: fix inconsistent function name in comment #21026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ws-daemon/pkg/iws/uidmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func WriteMapping(hostPID uint64, gid bool, mapping []*api.WriteIDMappingRequest
return nil
}

// findHosPID translates an in-container PID to the root PID namespace.
// findHostPID translates an in-container PID to the root PID namespace.
func (m *Uidmapper) findHostPID(containerPID, inContainerPID uint64) (uint64, error) {
paths := []string{fmt.Sprint(containerPID)}
seen := make(map[string]struct{})
Expand Down
2 changes: 1 addition & 1 deletion components/ws-manager-mk2/controllers/workspace_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ func (r *WorkspaceReconciler) deleteSecret(ctx context.Context, name, namespace
return err
}

// errorLogConflict logs the error if it's a conflict, instead of returning it as a reconciler error.
// errorResultLogConflict logs the error if it's a conflict, instead of returning it as a reconciler error.
// This is to reduce noise in our error logging, as conflicts are to be expected.
// For conflicts, instead a result with `Requeue: true` is returned, which has the same requeuing
// behaviour as returning an error.
Expand Down