Fix minio ws download

[corneliusludmann]

Fixes #2593

[geropl]

I think removing http2 is ok because:

• scenarios in which nginx is the front-facing proxy is self-hosted only, and there we don't know (yet) of large installations, so having the increase in connection count (due to the loss of multiplexing) is ok
• all other scenarios we have a LB that downgrades to HTTP1.x anyways

Regarding the stage: This change will break all existing Gitpod Self-Hosted installations. Do we want to be backwards compatible here?

[csweichel]

We left out the stage on purpose. It was required for GCP because there buckets are global, but not so in MinIO.
I don't think we should introduce the stage here. In the past we've had to introduce several indirections and have multiple places where we map one stage name to another (they happen to change over time).

Instead, we should remove the bucket name computation from the server and do everything in the content-service.
All other components (ws-manager for FWB and ws-daemon) already use content-service for this purpose.

[csweichel]

I reckon the -http2 change has unintended side-effects. nginx crashes with

021/01/04 07:52:40 [emerg] 1#1: BIO_new_file("/etc/nginx/certificates/fullchain.pem") failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/etc/nginx/certificates/fullchain.pem','r') error:2006D080:BIO routines:BIO_new_file:no such file)
nginx: [emerg] BIO_new_file("/etc/nginx/certificates/fullchain.pem") failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/etc/nginx/certificates/fullchain.pem','r') error:2006D080:BIO routines:BIO_new_file:no such file)

[corneliusludmann]

I reckon the -http2 change has unintended side-effects. nginx crashes with

021/01/04 07:52:40 [emerg] 1#1: BIO_new_file("/etc/nginx/certificates/fullchain.pem") failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/etc/nginx/certificates/fullchain.pem','r') error:2006D080:BIO routines:BIO_new_file:no such file)
nginx: [emerg] BIO_new_file("/etc/nginx/certificates/fullchain.pem") failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/etc/nginx/certificates/fullchain.pem','r') error:2006D080:BIO routines:BIO_new_file:no such file)

@csweichel: I think this error is independent and occurs when the SSL certificates are missing. See also #2569.

[csweichel]

I'm not sure those are related. If I create a fresh deployment without HTTPS from master the proxy runs just fine without fullchain.pem.

[csweichel]

It doesn't really make sense that removing http2 support should introduce the "no certificate crashes proxy" issue.
That said, I wonder why we're not seeing this issue when deploying a fresh branch from master, and what would happen if we merged this and ended up with a broken master. That said, considering #2655, that might not be a problem for long :)

Let's merge and see.