[registry-facade] Remove feature flag

[csweichel]

This PR removes all variance surrounding registry-facade. Once this is merged, registry-facade is the sole way to start workspaces. To this end, we remove

• the registry_facade feature flag and all variance it created in ws-manager
• node-daemon entirely. The remaining few sysctls are now an init container on ws-daemon
• Theia's static-server, because now that registry-facade is standard, so is blobserve.

How to test

1. Start a workspace - if it starts, all is well

fixes #2655

[corneliusludmann]

With the change in the ws-proxy-configmap.yaml above it's still possible that the blobServer config is missing (when blobserve component is disabled). Doesn't that conflict with removing this case here?

[corneliusludmann]

I have also found a few lines with references to node-daemon. 😆

gitpod/chart/templates/ws-manager-configmap.yaml

Line 81 in ff9d321

"theiaHostPath": "{{ .Values.components.nodeDaemon.theiaHostBasePath }}/theia/theia-{{ .Values.version }}",

This one breaks helm run when not using values.dev.yaml. This is because values.dev.yaml has:

gitpod/.werft/values.dev.yaml

Lines 114 to 116 in ff9d321

	# Use Hosts SSD for perf and to not spam the boot disk
	nodeDaemon:
	theiaHostBasePath: /mnt/disks/ssd0

And here are two self-hosted files with references to node-daemon. Don't know if you want to address it in this PR as well or create an issue for this:

gitpod/docs/self-hosted/install/nodes.md

Lines 29 to 33 in ff9d321

	nodeDaemon:
	# Gitpod copies Theia to each node. This setting configures where Theia is copied to.
	# We'll copy Theia to $theiaHostBasePath/theia/theia-$version
	# The faster this location is (in terms of IO) the faster nodes will become available and the faster workspaces will start.
	theiaHostBasePath: /mnt/disks/ssd0

gitpod/install/gcp-terraform/modules/gitpod/templates/values.node-layout.tpl

Lines 5 to 9 in ff9d321

	nodeDaemon:
	# Gitpod copies Theia to each node. This setting configures where Theia is copied to.
	# We'll copy Theia to $theiaHostBasePath/theia/theia-$version
	# The faster this location is (in terms of IO) the faster nodes will become available and the faster workspaces will start.
	theiaHostBasePath: /mnt/disks/ssd0

[csweichel]

Thank you for pointing those bits out. I've gone over the PR one more time and removed these bits.

[corneliusludmann]

Tested with the preview environment and self-hosted (k3s image). Both work fine.