[dashboard] Improve new workspace start experience ⚡ #3510
Conversation
jankeromnes
force-pushed
the
jx/dash2-fresh-start
branch
5 times, most recently
from
184e36c to
65c6548
Compare
jankeromnes
force-pushed
the
jx/dash2-fresh-start
branch
from
65c6548 to
4a8e911
Compare
|
Alrighty, workspace start-up (phases/status/controls) should be much nicer✨ and feel faster⚡ now! Also includes basic Stopping and Stopped screens. 🚀 Ready for review. |
jankeromnes
requested review from
gtsiolis and
svenefftinge
and removed request for
gtsiolis
|
A few screenshots (note: the logo now bounces):
|
There was a problem hiding this comment.
Je vous remercie @jankeromnes! ⭐
Let some minor comments we can tackle in follow up issues.
| <div className="rounded-full w-3 h-3 text-sm bg-gitpod-kumquat"> </div> | ||
| <div> | ||
| <p className="text-gray-700 font-semibold">{this.state.workspaceInstance.workspaceId}</p> | ||
| <p>{this.state.contextUrl}</p> |
There was a problem hiding this comment.
issue: Let's truncate this as it can break the layout for this component!
There was a problem hiding this comment.
Moved to #3507 (comment).
| break; | ||
|
|
||
| // Stopping means that the workspace is currently shutting down. It could go to stopped every moment. | ||
| case "stopping": | ||
| statusMessage = <p className="text-base text-gray-400">Stopping …</p>; | ||
| phase = StartPhase.Stopping; | ||
| statusMessage = <div> |
There was a problem hiding this comment.
issue: Can we center align all the elements within this div and also keep a fix width for the workspace reference?
There was a problem hiding this comment.
Moved to #3507 (comment).
| </div> | ||
| <div className="mt-10 flex space-x-2"> | ||
| <button className="px-4 py-2 text-gray-500 bg-white font-semibold border-gray-500" onClick={() => this.redirectTo(gitpodHostUrl.asDashboard().toString())}>Go to Dashboard</button> | ||
| <button className="px-4 py-2 text-gray-50 bg-green-600 font-semibold border-green-800" onClick={() => this.redirectTo(gitpodHostUrl.asStart(this.state.workspaceInstance?.workspaceId).toString())}>Open Workspace</button> |
There was a problem hiding this comment.
issue: Both of these buttons lack hover state. Maybe we could add this on the button component in index.css.
There was a problem hiding this comment.
Moved to #3507 (comment).
No description provided.