[dashboard] Welcome existing users to new updates #3618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/whats-new
branch
2 times, most recently
from
7a04bd7 to
c471047
Compare
svenefftinge
force-pushed
the
se/whats-new
branch
from
c471047 to
93f2069
Compare
|
/werft run 👍 started the job as gitpod-build-se-whats-new.5 |
|
Looking at this now! 👀 |
gtsiolis
approved these changes
Mar 29, 2021
| return <Modal visible={props.visible} onClose={internalClose}> | ||
| <h3 className="pb-4">What's New 🎁</h3> | ||
| <div className="border-t border-gray-200 -mx-6 px-6 py-4"> | ||
| <p className="pb-2 text-gray-900 text-base">New Dashboard</p> |
There was a problem hiding this comment.
nitpick: Minor font weight fix.
Suggested change
| <p className="pb-2 text-gray-900 text-base">New Dashboard</p> | |
| <p className="pb-2 text-gray-900 text-base font-medium">New Dashboard</p> |
| <p className="pb-2 text-gray-500 text-sm">We have made some layout changes on the dashboard to improve the overall user experience of the product.</p> | ||
| </div> | ||
| <div className="border-t border-b border-gray-200 -mx-6 px-6 py-4"> | ||
| <p className="pb-2 text-gray-900 text-base">VS Code</p> |
There was a problem hiding this comment.
nitpick: Minor font weight fix.
Suggested change
| <p className="pb-2 text-gray-900 text-base">VS Code</p> | |
| <p className="pb-2 text-gray-900 text-base font-medium">VS Code</p> |
| <li className="ml-5"> | ||
| <div> | ||
| <p className="text-gray-500 text-sm">We're preserving all <span className="font-bold">user settings and extensions</span>.</p> | ||
| <p className="text-gray-400 text-xs">Extensions you have manually uploaded are not transfered. You'll need to search and install those extensions through the extension panel in VS Code.</p> |
There was a problem hiding this comment.
suggestion: This one hurt a bit! We could try to not go below text-sm (14px) anywhere across the product for legibility and readability. 😅
Suggested change
| <p className="text-gray-400 text-xs">Extensions you have manually uploaded are not transfered. You'll need to search and install those extensions through the extension panel in VS Code.</p> | |
| <p className="text-gray-400 text-sm">Extensions you have manually uploaded are not transfered. You'll need to search and install those extensions through the extension panel in VS Code.</p> |
| <li className="ml-5"> | ||
| <div> | ||
| <p className="text-gray-500 text-sm">We've reduced the number of <span className="font-bold">pre-installed extensions</span>.</p> | ||
| <p className="text-gray-400 text-xs">The old editor would come with extensions for the most popular programming languages pre-installed. You are now freed from that additional bloat but should consider installing any extensions you miss.</p> |
There was a problem hiding this comment.
Suggested change
| <p className="text-gray-400 text-xs">The old editor would come with extensions for the most popular programming languages pre-installed. You are now freed from that additional bloat but should consider installing any extensions you miss.</p> | |
| <p className="text-gray-400 text-sm">The old editor would come with extensions for the most popular programming languages pre-installed. You are now freed from that additional bloat but should consider installing any extensions you miss.</p> |
| <li className="ml-5"> | ||
| <div> | ||
| <p className="text-gray-500 text-sm">You can still <span className="font-bold">switch the editor back</span> to the old one.</p> | ||
| <p className="text-gray-400 text-xs">In case you run into trouble with the new IDE, you can go to the settings and switch back to the old editor (Theia).</p> |
There was a problem hiding this comment.
Suggested change
| <p className="text-gray-400 text-xs">In case you run into trouble with the new IDE, you can go to the settings and switch back to the old editor (Theia).</p> | |
| <p className="text-gray-400 text-sm">In case you run into trouble with the new IDE, you can go to the settings and switch back to the old editor (Theia).</p> |
| <li className="ml-5"> | ||
| <div> | ||
| <p className="text-gray-500 text-sm">We're preserving all <span className="font-bold">user settings and extensions</span>.</p> | ||
| <p className="text-gray-400 text-xs">Extensions you have manually uploaded are not transfered. You'll need to search and install those extensions through the extension panel in VS Code.</p> |
There was a problem hiding this comment.
praise: Love the rephrase of the last part.
You'll need to search and install those extensions through the extension panel in VS Code.
| <li className="ml-5"> | ||
| <div> | ||
| <p className="text-gray-500 text-sm">We've reduced the number of <span className="font-bold">pre-installed extensions</span>.</p> | ||
| <p className="text-gray-400 text-xs">The old editor would come with extensions for the most popular programming languages pre-installed. You are now freed from that additional bloat but should consider installing any extensions you miss.</p> |
There was a problem hiding this comment.
issue: Words freed, should, and old here sound a bit harsh. Also, reffering to an old editor could be confusing in the future. Let me try to rephrase this but I'll leave this up to you to decide.
Suggested change
| <p className="text-gray-400 text-xs">The old editor would come with extensions for the most popular programming languages pre-installed. You are now freed from that additional bloat but should consider installing any extensions you miss.</p> | |
| <p className="text-gray-400 text-xs">Theia editor included pre-installed extensions for the most popular programming languages which added additional bloat. You can now optionally consider installing any extensions you need.</p> |
| </li> | ||
| <li className="ml-5"> | ||
| <div> | ||
| <p className="text-gray-500 text-sm">You can still <span className="font-bold">switch the editor back</span> to the old one.</p> |
There was a problem hiding this comment.
issue: Minor removal of the old term reference.
Suggested change
| <p className="text-gray-500 text-sm">You can still <span className="font-bold">switch the editor back</span> to the old one.</p> | |
| <p className="text-gray-500 text-sm">You can still <span className="font-bold">switch the editor</span> to Theia.</p> |
| </ol> | ||
| </div> | ||
| <div className="flex justify-end mt-6"> | ||
| <button className="text-gray-900 border-white bg-white hover:border-gray-200" onClick={() => internalClose()}>Dismiss</button> |
There was a problem hiding this comment.
thought: This should become a secondary button after #3620, right?
svenefftinge
force-pushed
the
se/whats-new
branch
from
93f2069 to
ef4aa3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3297