[dashboard] Improve and fix workspace details on workspace list #3627
Conversation
|
/werft run 👍 started the job as gitpod-build-se-workspace-entries.2 |
|
/werft run 👍 started the job as gitpod-build-se-workspace-entries.3 |
svenefftinge
force-pushed
the
se/workspace-entries
branch
from
90f9d41 to
c237195
Compare
|
/werft run 👍 started the job as gitpod-build-se-workspace-entries.5 |
|
/werft run 👍 started the job as gitpod-build-se-workspace-entries.6 |
|
Looking at this now! 👀 |
| <div className="text-sm text-gray-400 truncate">{moment(WorkspaceInfo.lastActiveISODate(desc)).fromNow()}</div> | ||
| <div className="flex w-2/12 self-center"> | ||
| <Tooltip content={`Created ${moment(desc.workspace.creationTime).fromNow()}`}> | ||
| <div className="text-sm w-full text-gray-400 truncate">{moment(WorkspaceInfo.lastActiveISODate(desc)).fromNow()}</div> |
There was a problem hiding this comment.
suggestion: It's safe to remove the cursor pointer here. WDYT?
| <div className={stateClassName}> | ||
| | ||
| </div> | ||
| <Tooltip content={state}> |
There was a problem hiding this comment.
issue: Looks great! The lowercase stopping state is coming from the backend, right? Worth opening a follow up issue to update this to Stopping if possible? WDYT?
There was a problem hiding this comment.
Yeah, I can do a translation in this PR already.
| <div className={stateClassName}> | ||
| | ||
| </div> | ||
| <Tooltip content={state}> |
There was a problem hiding this comment.
suggestion: It's safe to remove the cursor pointer here. WDYT?
| </div> | ||
| <div className="flex flex-col w-3/12"> | ||
| <div className="font-medium text-gray-800 truncate">{ws.id}</div> | ||
| <a href={project ? 'https://' + project : undefined}><div className="text-sm overflow-ellipsis truncate text-gray-400">{project || 'Unknown'}</div></a> | ||
| <a href={startUrl.toString()}><div className="font-medium text-gray-800 truncate hover:text-blue-500">{ws.id}</div></a> |
There was a problem hiding this comment.
thought: The idea was to have a rounded background on hover as in the pending changes column. Blue is not a color we've used for links elsewhere but let's get this is and fine tune within this week.
There was a problem hiding this comment.
We decided to go with blue-600.
| content: string; | ||
| } | ||
|
|
||
| function Tooltip(props: TooltipProps) { |
There was a problem hiding this comment.
praise: Welcome, tooltip component! 🎈
svenefftinge
force-pushed
the
se/workspace-entries
branch
from
c237195 to
12f256f
Compare
- added tooltips - removed <a/> around entire element - aded links and hover effects on individual elements
svenefftinge
force-pushed
the
se/workspace-entries
branch
from
12f256f to
0622f16
Compare
|
/werft run 👍 started the job as gitpod-build-se-workspace-entries.9 |
Untitled.mov