Update port-not-found.html #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/port-not-found
branch
5 times, most recently
from
d9e50b8 to
6ab672e
Compare
svenefftinge
force-pushed
the
se/port-not-found
branch
from
6ab672e to
4d7572a
Compare
svenefftinge
force-pushed
the
se/port-not-found
branch
from
4d7572a to
3e60289
Compare
gtsiolis
suggested changes
Mar 29, 2021
| <link rel="icon" type="image/png" href="https://gitpod.io/images/gitpod-196x196.png" sizes="196x196" /> | ||
| <link rel="icon" type="image/svg+xml" href="https://gitpod.io/images/gitpod.svg" sizes="any" /> | ||
| <link rel="stylesheet" href="//fonts.googleapis.com/css?family=Montserrat" /> | ||
| <title>Workspace Port Not Found - Gitpod</title> |
There was a problem hiding this comment.
praise: Thanks for adding product title at the end of the title here. We should change all dashboard titles to follow this pattern, currently using product as a prefix. Feel free to leave this out of the scope of this PR.
There was a problem hiding this comment.
Added follow up issue in #3653.
| @@ -241,7 +241,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps, | |||
| </div> | |||
| </div> | |||
| <div className="mt-10 flex"> | |||
| <button className="mx-auto px-4 py-2 text-gray-500 bg-white font-semibold border-gray-500 hover:text-gray-700 hover:border-gray-700 hover:bg-gray-100" onClick={() => this.redirectTo(gitpodHostUrl.asDashboard().toString())}>Go to Dashboard</button> | |||
| <button className="secondary" onClick={() => this.redirectTo(gitpodHostUrl.asDashboard().toString())}>Go to Dashboard</button> | |||
| text-align: center; | ||
| letter-spacing: 0.04em; | ||
|
|
||
| /* Gray 400 */ |
There was a problem hiding this comment.
thought: Poor gray-400, who knew you would end up in a comment here. 🙂
svenefftinge
force-pushed
the
se/port-not-found
branch
from
3e60289 to
a17dd03
Compare
|
/werft run 👍 started the job as gitpod-build-se-port-not-found.10 |
|
/werft run 👍 started the job as gitpod-build-se-port-not-found.11 |
gtsiolis
reviewed
Mar 29, 2021
Comment on lines
76
to
77
| font-size: 48px; | ||
| line-height: 64px; |
There was a problem hiding this comment.
Ah, wait. Let's only change this to the small page title size as seen in #3588. WDYT?
Suggested change
| font-size: 48px; | |
| line-height: 64px; | |
| font-size: 32px; | |
| line-height: 40px; |
svenefftinge
force-pushed
the
se/port-not-found
branch
from
2397004 to
f6d7031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3587
Also fixes a dashboard bug that was introduced in a previous PR.