[dashboard] Admin dashboard #3723

svenefftinge · 2021-04-02T09:46:25Z

Adds the admin dashboard to the new dashboard.

How to test:

create a user with 'admin' flag (default in dev staging)
you should see the admin menu on top.
try search for users or workspaces.

svenefftinge · 2021-04-03T14:51:53Z

/werft run

👍 started the job as gitpod-build-sefftinge-dashboard-admin-dashboard-3359.7

svenefftinge · 2021-04-04T13:47:29Z

/werft run

👍 started the job as gitpod-build-sefftinge-dashboard-admin-dashboard-3359.10

svenefftinge · 2021-04-04T13:49:32Z

/werft run

👍 started the job as gitpod-build-sefftinge-dashboard-admin-dashboard-3359.11

svenefftinge · 2021-04-04T15:41:17Z

components/licensor/typescript/ee/src/index.ts

@@ -42,23 +42,26 @@ export class LicenseEvaluator {
    }

    public validate(): { msg?: string, valid: boolean } {
-        const v = validate(this.instanceID);
-        if (v.valid) {
+        // const v = validate(this.instanceID);


TODO: revert these changes

gtsiolis · 2021-04-05T06:47:48Z

/werft run

👍 started the job as gitpod-build-sefftinge-dashboard-admin-dashboard-3359.14

gtsiolis

Estupendo! Great to this coming to life. 🌟

Two points to consider:

For some reason, I cannot start a workspace anymore. 💡
As long as we have the functionality in place it should be good to ship. 🚢

gtsiolis · 2021-04-05T07:13:19Z

components/dashboard/src/App.tsx

+        left.push({
+            title: 'Admin',
+            link: '/admin',
+            alternatives: adminMenu.flatMap(e => e.link)


thought: I assume this hides the Admin menu for unauthorized users, right?

Yes, you can test it by logging in with another user and then remove the admin role from it.

gtsiolis · 2021-04-05T07:16:00Z

components/dashboard/src/admin/WorkspacesSearch.tsx

+                            <path fillRule="evenodd" clipRule="evenodd" d="M6 2a4 4 0 100 8 4 4 0 000-8zM0 6a6 6 0 1110.89 3.477l4.817 4.816a1 1 0 01-1.414 1.414l-4.816-4.816A6 6 0 010 6z" fill="#A8A29E" />
+                        </svg>
+                    </div>
+                    <input className="border-0" type="text" placeholder="Search in context urls" onKeyDown={(ke) => ke.key === 'Enter' && search() } onChange={(v) => { setSearchTerm(v.target.value) }} />


thought: This is probably more accurate but could suffice as Search Workspaces. Let's keep it as is!

Suggested change

<input className="border-0" type="text" placeholder="Search in context urls" onKeyDown={(ke) => ke.key === 'Enter' && search() } onChange={(v) => { setSearchTerm(v.target.value) }} />

<input className="border-0" type="text" placeholder="Search context URLs" onKeyDown={(ke) => ke.key === 'Enter' && search() } onChange={(v) => { setSearchTerm(v.target.value) }} />

I made it explicit, because it only searches in context urls so for instance not in workspace ids.

gtsiolis · 2021-04-05T07:19:10Z

components/dashboard/src/admin/WorkspacesSearch.tsx

+function WorkspaceEntry(p: { ws: WorkspaceAndInstance }) {
+    return <Link to={'/admin/workspaces/' + p.ws.workspaceId}>
+        <div className="rounded-xl whitespace-nowrap flex space-x-2 py-6 px-6 w-full justify-between hover:bg-gray-100 focus:bg-gitpod-kumquat-light group">
+            <div className="pr-3 self-center w-1/12">


issue: This is making the tooltip show up slightly offset.

It seems fixed in the preview environment. 🧀

Yes, I fixed it already in my workspace :-)

gtsiolis · 2021-04-05T07:39:51Z

components/dashboard/src/admin/WorkspacesSearch.tsx

+                <div className="font-medium text-gray-800 truncate hover:text-blue-600">{p.ws.workspaceId}</div>
+                <div className="text-sm overflow-ellipsis truncate text-gray-400">{getProject(WorkspaceAndInstance.toWorkspace(p.ws))}</div>
+            </div>
+            <div className="flex w-4/12 self-center">


issue: Some columns overlap and the list is also overflowing from the container on medium viewports! 🙀

Column Container

It seems fixed in the preview environment. 🧀

gtsiolis · 2021-04-05T08:11:01Z

components/dashboard/src/admin/UserSearch.tsx

+                    </div>
+                    <input className="border-0" type="text" placeholder="Search Users" onKeyDown={(ke) => ke.key === 'Enter' && search() } onChange={(v) => { setSearchTerm(v.target.value) }} />
+                </div>
+                <button className="" disabled={searching} onClick={search}>Start Search</button>


suggestion: No need to prefix this with Start.

Suggested change

<button className="" disabled={searching} onClick={search}>Start Search</button>

<button className="" disabled={searching} onClick={search}>Search</button>

gtsiolis · 2021-04-05T08:35:55Z

components/dashboard/src/admin/WorkspaceDetail.tsx

+                <p>{getProject(WorkspaceAndInstance.toWorkspace(workspace))}</p>
+            </div>
+            <button className="secondary ml-3" disabled={activity} onClick={reload}>Reload Data</button>
+            <button className="danger ml-3" disabled={activity || workspace.phase === 'stopped'} onClick={stopWorkspace}>Stop Workspaces</button>


question: Shouldn't this read Stop Workspace?

Suggested change

<button className="danger ml-3" disabled={activity || workspace.phase === 'stopped'} onClick={stopWorkspace}>Stop Workspaces</button>

<button className="danger ml-3" disabled={activity || workspace.phase === 'stopped'} onClick={stopWorkspace}>Stop Workspace</button>

gtsiolis · 2021-04-05T08:40:55Z

components/dashboard/src/admin/UserSearch.tsx

+                <div className="w-5/12">Created</div>
+            </div>
+        </div>
+        {searchResult.rows.filter(u => u.identities.length > 0).map(u => <UserEntry user={u} />)}


thought: I still find this empty data set on load slightly confusing but I understand this helps us avoid some performance costs. Let's leave it as is for now. 🎯

We should possibly show an empty list place holder (later).

gtsiolis · 2021-04-05T08:42:20Z

components/dashboard/src/admin/UserDetail.tsx

+    return <div className={`ml-3 text-sm text-${p.color}-600 truncate bg-${p.color}-100 px-1.5 py-0.5 rounded-md my-auto`}>{p.text}</div>;
+}
+
+export function Property(p: { name: string, children: string | ReactChild, action?: { label: string, onClick: () => void } }) {


praise: Nice abstraction here!

gtsiolis · 2021-04-05T08:44:30Z

components/dashboard/src/admin/UserDetail.tsx

+            {p.name}
+        </div>
+        <div className="text-lg text-gray-600 font-semibold truncate">
+            {p.children}


issue: Latest Instance ID bring in some overflow-scroll. Known?

Yes, it is on purpose so I can actually see and copy the whole ID.

gtsiolis · 2021-04-05T08:46:17Z

components/dashboard/src/admin/WorkspaceDetail.tsx

+                <div className="flex"><h3>{workspace.workspaceId}</h3><span className="my-auto ml-3"><WorkspaceStatusIndicator instance={WorkspaceAndInstance.toInstance(workspace)} /></span></div>
+                <p>{getProject(WorkspaceAndInstance.toWorkspace(workspace))}</p>
+            </div>
+            <button className="secondary ml-3" disabled={activity} onClick={reload}>Reload Data</button>


question: No more Download Workspace button?

It doesn't work AFAIK

svenefftinge force-pushed the sefftinge/dashboard-admin-dashboard-3359 branch 4 times, most recently from ff27e38 to 47694f5 Compare April 2, 2021 16:55

svenefftinge force-pushed the sefftinge/dashboard-admin-dashboard-3359 branch 2 times, most recently from e4ec8bb to fe9bed9 Compare April 4, 2021 07:42

svenefftinge force-pushed the sefftinge/dashboard-admin-dashboard-3359 branch from fe9bed9 to 1a7bd2c Compare April 4, 2021 15:39

svenefftinge marked this pull request as ready for review April 4, 2021 15:39

svenefftinge commented Apr 4, 2021

View reviewed changes

svenefftinge force-pushed the sefftinge/dashboard-admin-dashboard-3359 branch from 1a7bd2c to 5aec9c7 Compare April 4, 2021 15:44

svenefftinge requested a review from gtsiolis April 4, 2021 15:44

gtsiolis approved these changes Apr 5, 2021

View reviewed changes

[dashboard] Admin dashboard

a56ef7e

svenefftinge force-pushed the sefftinge/dashboard-admin-dashboard-3359 branch from 5aec9c7 to a56ef7e Compare April 5, 2021 09:42

svenefftinge merged commit bf5e0de into main Apr 5, 2021

svenefftinge deleted the sefftinge/dashboard-admin-dashboard-3359 branch April 5, 2021 09:52

gtsiolis mentioned this pull request Oct 22, 2021

Allow admin users to download workspaces #6351

Closed

2 tasks

gtsiolis mentioned this pull request Mar 2, 2022

Remove free text search on contextURL #8503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dashboard] Admin dashboard #3723

[dashboard] Admin dashboard #3723

svenefftinge commented Apr 2, 2021 •

edited

Loading

svenefftinge commented Apr 3, 2021 •

edited by werft-gitpod-dev-com bot

Loading

svenefftinge commented Apr 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

svenefftinge commented Apr 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

svenefftinge Apr 4, 2021

gtsiolis commented Apr 5, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

gtsiolis Apr 5, 2021

svenefftinge Apr 5, 2021

gtsiolis Apr 5, 2021

svenefftinge Apr 5, 2021

gtsiolis Apr 5, 2021

gtsiolis Apr 5, 2021

svenefftinge Apr 5, 2021

gtsiolis Apr 5, 2021

gtsiolis Apr 5, 2021

gtsiolis Apr 5, 2021

gtsiolis Apr 5, 2021

gtsiolis Apr 5, 2021

svenefftinge Apr 5, 2021

gtsiolis Apr 5, 2021

gtsiolis Apr 5, 2021

svenefftinge Apr 5, 2021

gtsiolis Apr 5, 2021

svenefftinge Apr 5, 2021

	<input className="border-0" type="text" placeholder="Search in context urls" onKeyDown={(ke) => ke.key === 'Enter' && search() } onChange={(v) => { setSearchTerm(v.target.value) }} />
	<input className="border-0" type="text" placeholder="Search context URLs" onKeyDown={(ke) => ke.key === 'Enter' && search() } onChange={(v) => { setSearchTerm(v.target.value) }} />

	<button className="" disabled={searching} onClick={search}>Start Search</button>
	<button className="" disabled={searching} onClick={search}>Search</button>

	<button className="danger ml-3" disabled={activity \|\| workspace.phase === 'stopped'} onClick={stopWorkspace}>Stop Workspaces</button>
	<button className="danger ml-3" disabled={activity \|\| workspace.phase === 'stopped'} onClick={stopWorkspace}>Stop Workspace</button>

[dashboard] Admin dashboard #3723

[dashboard] Admin dashboard #3723

Conversation

svenefftinge commented Apr 2, 2021 • edited Loading

svenefftinge commented Apr 3, 2021 • edited by werft-gitpod-dev-com bot Loading

svenefftinge commented Apr 4, 2021 • edited by werft-gitpod-dev-com bot Loading

svenefftinge commented Apr 4, 2021 • edited by werft-gitpod-dev-com bot Loading

Choose a reason for hiding this comment

gtsiolis commented Apr 5, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

svenefftinge commented Apr 2, 2021 •

edited

Loading

svenefftinge commented Apr 3, 2021 •

edited by werft-gitpod-dev-com bot

Loading

svenefftinge commented Apr 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

svenefftinge commented Apr 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Apr 5, 2021 •

edited by werft-gitpod-dev-com bot

Loading