[dashboard] fix sharing #3756
Merged
[dashboard] fix sharing #3756
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
sefftinge/dashboard-share-workspace-3755
branch
from
990272b to
2b1b7ba
Compare
svenefftinge
commented
Apr 6, 2021
| const ws = this.workspaces.get(workspaceId)?.workspace; | ||
| if (ws) { | ||
| ws.shareable = !ws.shareable; | ||
| getGitpodService().server.controlAdmission(ws.id, ws.shareable ? "owner" : "everyone"); | ||
| await getGitpodService().server.controlAdmission(ws.id, ws.shareable ? "everyone" : "owner"); |
There was a problem hiding this comment.
the fix is the switch of the ternary operands.
gtsiolis
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.