[dashboard] Add a few minor missing pages #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/minor-missing-pages
branch
2 times, most recently
from
620cb0d to
cf754c4
Compare
|
How to test: https://jx-minor-missing-pages.staging.gitpod-dev.com/login, then: |
This comment has been minimized.
This comment has been minimized.
jankeromnes
force-pushed
the
jx/minor-missing-pages
branch
3 times, most recently
from
bf8ed0c to
8b364ed
Compare
|
Current state:
|
jankeromnes
force-pushed
the
jx/minor-missing-pages
branch
from
8b364ed to
f542176
Compare
jankeromnes
commented
Apr 6, 2021
| <p className="mt-4 text-lg text-gitpod-red">{decodeURIComponent(getURLHash())}</p> | ||
| </div> | ||
| </Route> | ||
| <Route path="*" /* status={404} */> |
There was a problem hiding this comment.
Would be nice to send an actual HTTP 404 status code here, but this requires some server-side hook.
|
some misalignment on the "blocked" page |
jankeromnes
force-pushed
the
jx/minor-missing-pages
branch
from
f542176 to
e53b23a
Compare
Thanks. Fixed. |
gtsiolis
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Thanks @jankeromnes for adding instructions how to check these changes!
Looks like a great MVC! 🧱
gtsiolis
approved these changes
Apr 6, 2021
This was referenced Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing from https://github.com/gitpod-com/gitpod/issues/5233: