Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fixing layout issues #3845

Merged
merged 1 commit into from
Apr 15, 2021
Merged

[dashboard] fixing layout issues #3845

merged 1 commit into from
Apr 15, 2021

Conversation

AlexTugarev
Copy link
Member

if page width is less than lx the tree dot button wasn't visible for team subscriptions. also the permissions column blew up the layout.

@AlexTugarev AlexTugarev requested a review from gtsiolis April 8, 2021 11:48
@@ -484,7 +484,7 @@ function AllTeams() {
Payment in Progress
</div>
</div>
<div className="my-auto flex w-1/12 pl-8 opacity-0 group-hover:opacity-100">
<div className="my-auto flex w-1/12 opacity-0 group-hover:opacity-100 justify-end">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtsiolis, I know there is no tester for this change in core :-(
but you can compare the styles with the environment variables page. it's just aligned.

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 12, 2021

Looking at this now! 👀

/werft run

👍 started the job as gitpod-build-at-fix-layout.2

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 13, 2021

Really looking at this now! 😇

/werft run

👍 started the job as gitpod-build-at-fix-layout.3

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 13, 2021

Oh, no. Build failed, retrying.

/werft run

👍 started the job as gitpod-build-at-fix-layout.4

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Apr 13, 2021

/werft run

👍 started the job as gitpod-build-at-fix-layout.5

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AlexTugarev! Thanks for bringing back the more actions button. The rest of the columns seem to have some alignment issues. Left some two comments below, let me know what you think. 💭

components/dashboard/src/settings/Integrations.tsx Outdated Show resolved Hide resolved
components/dashboard/src/settings/Integrations.tsx Outdated Show resolved Hide resolved
if page width is less than `lx` the tree dot  button wasn't visible for team subscriptions. also the permissions column blew up the layout.
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Apr 14, 2021

/werft run

👍 started the job as gitpod-build-at-fix-layout.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants