Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Allow restoring a soft-deleted workspace from the admin dashboard #3955

Merged
merged 1 commit into from
Apr 16, 2021
Merged

[dashboard] Allow restoring a soft-deleted workspace from the admin dashboard #3955

merged 1 commit into from
Apr 16, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Apr 15, 2021 •
edited
Loading

Fixes #3163

Enterprise / SaaS feature (admin dashboard).

How to test:

  1. Log in to the IO preview (see also IO branch, IO werft job)
  2. Become admin (ask me or see how)
  3. Start a workspace
  4. Delete the workspace
  5. Go to the admin dashboard, see that the workspace has been soft-deleted ('user'), click to Restore & Pin it
  6. Voilà

@jankeromnes jankeromnes marked this pull request as ready for review April 15, 2021 15:39
@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 16, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jx-un-soft-delete.5

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 16, 2021 •
edited
Loading

Looking at this now! 👀 Not yet! Will be back soon.

@jankeromnes jankeromnes requested a review from AlexTugarev April 16, 2021 16:52
@AlexTugarev
Copy link
Member

AlexTugarev commented Apr 16, 2021 •
edited by werft-gitpod-dev-com bot
Loading

2021-04-16 19 38 51

👏🏻

AlexTugarev
AlexTugarev approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! Thanks @jankeromnes !

@jankeromnes jankeromnes merged commit b92b12d into main Apr 16, 2021
@jankeromnes jankeromnes deleted the jx/un-soft-delete branch April 16, 2021 18:26
@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 16, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Thanks for picking this up @AlexTugarev! FWIW, first MVC for this looks good!

This will save us a couple of hours from manually searching through the database. Great addition @jankeromnes! 🌟

@jankeromnes jankeromnes mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

@meysholdt meysholdt Awaiting requested review from meysholdt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin Dashboard should allow un-delete, if possible
3 participants
@jankeromnes @gtsiolis @AlexTugarev