Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Change default theme from 'system' to 'light' #4084

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Apr 27, 2021

Reasons:

  • Don't surprise users with a different default theme & no further explanation (we don't have a "What's New" modal for the April release)
  • Align with the default theme of the IDE

In a future iteration, we can still switch both the dashboard and the IDE to "system" by default, and announce it with a "What's New" modal.

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 27, 2021

Looking at this now! 👀

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in @jankeromnes! Works like a charm! 🔮 🌙

This one also seems like a two-way door decision which we can revert later or change to system as the default option if needed.

@jankeromnes jankeromnes merged commit 10834be into main Apr 27, 2021
@jankeromnes jankeromnes deleted the jx/default-light-theme branch April 27, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants