[dashboard] Don't show 'Continue with Default Image' button while the build is still running #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
changed the title
…prevent restart spam
jankeromnes
force-pushed
the
jx/dont-continue-with-default-img
branch
from
ac8802b to
c6d6cf1
Compare
AlexTugarev
reviewed
Apr 29, 2021
| @@ -267,7 +267,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps, | |||
| case "stopped": | |||
| phase = StartPhase.Stopped; | |||
| if (this.state.hasImageBuildLogs) { | |||
| return <ImageBuildView workspaceId={this.state.workspaceInstance.workspaceId} onStartWithDefaultImage={() => this.startWorkspace(true, true)} phase={phase} error={error} />; | |||
| return <ImageBuildView workspaceId={this.state.workspaceInstance.workspaceId} onStartWithDefaultImage={e => { (e.target as HTMLButtonElement).disabled = true; this.startWorkspace(true, true); }} phase={phase} error={error} />; | |||
There was a problem hiding this comment.
nit: the disablement is quite hidden now. would extracting to a dedicated handler as a local help to make it more readable?
jankeromnes
force-pushed
the
jx/dont-continue-with-default-img
branch
from
c6d6cf1 to
d0be03f
Compare
… build is still running
jankeromnes
force-pushed
the
jx/dont-continue-with-default-img
branch
from
d0be03f to
5774850
Compare
|
🎰 /werft run 👍 started the job as gitpod-build-jx-dont-continue-with-default-img.4 |
|
FWIW, Tried this earlier and worked as expected! 🎰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3777
While going down the rabbit hole of trying to fix the
Continue with Default Imagebutton while a build is still running in #3993, we realized that running Docker builds cannot be interrupted.image-buildersimply wasn't designed for that.So we have 3 choices:
Change
image-builderso that it can interrupt builds that are currently in progressJust start a new workspace instance while the old instance is still building, and live with having two instances in this case (breaks many assumptions in the code)
Remove the
Continue with Default Imagebutton while the build is still running, for now (this was also the case in the previous dashboard design -- button only showed up when the build finished / failed)This PR implements choice 3.
How to test:
Continue with Default Imagebutton (Docker build will hang for 1h)Continue with Default Imagebutton and that it works (Docker build will quickly fail)