[dashboard] Don't show 'Continue with Default Image' button while the build is still running #4104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3777
While going down the rabbit hole of trying to fix the
Continue with Default Image
button while a build is still running in #3993, we realized that running Docker builds cannot be interrupted.image-builder
simply wasn't designed for that.So we have 3 choices:
Change
image-builder
so that it can interrupt builds that are currently in progressJust start a new workspace instance while the old instance is still building, and live with having two instances in this case (breaks many assumptions in the code)
Remove the
Continue with Default Image
button while the build is still running, for now (this was also the case in the previous dashboard design -- button only showed up when the build finished / failed)This PR implements choice 3.
How to test:
Continue with Default Image
button (Docker build will hang for 1h)Continue with Default Image
button and that it works (Docker build will quickly fail)