Osf 3893 release 0.9.0 #4247
Closed
Osf 3893 release 0.9.0 #4247
+79
−4,856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade instructions - version bump - clarifictions/small fixes
geropl
force-pushed
the
osf-3893-release-0.9.0
branch
from
db934a9 to
73f4f8c
Compare
geropl
force-pushed
the
osf-3893-release-0.9.0
branch
from
73f4f8c to
25ece59
Compare
JanKoehnlein
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
LGTM.
Not sure whether we need @geropl's review as it's mostly deletions and docs.
csweichel
reviewed
Jun 9, 2021
| @@ -7,6 +7,10 @@ version: | |||
| hostname: localhost | |||
| certificatesSecret: | |||
| secretName: https-certificates | |||
| certName: cert.pem | |||
There was a problem hiding this comment.
This looks like a step backwards from the TLS secret type we're moving to
There was a problem hiding this comment.
This looks like a step backwards from the TLS secret type we're moving to
The goal here is to still support the certificates that come out of letsencrypt right away, by default. Otherwise we'd need to tell Self-Hosted users to do yet another step: https://www.gitpod.io/docs/self-hosted/latest/install/configure-ingress#using-lets-encrypt-to-generate-https-certificates
|
Closing out due to age and conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a cherry pick of the first commits from this PR #3925