Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitpod-cli] Fix parsing of env variables #4494

Merged
merged 1 commit into from
Jun 14, 2021
Merged

[gitpod-cli] Fix parsing of env variables #4494

merged 1 commit into from
Jun 14, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 12, 2021

fixes #4493

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #4494 (aea98dd) into main (34a5b02) will increase coverage by 13.05%.
The diff coverage is 72.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4494       +/-   ##
=========================================
+ Coverage      0   13.05%   +13.05%     
=========================================
  Files         0       14       +14     
  Lines         0     1042     +1042     
=========================================
+ Hits          0      136      +136     
- Misses        0      901      +901     
- Partials      0        5        +5     
Impacted Files Coverage Δ
components/gitpod-cli/cmd/env.go 26.04% <72.91%> (ø)
components/gitpod-cli/cmd/root.go 0.00% <0.00%> (ø)
components/gitpod-cli/cmd/open.go 4.54% <0.00%> (ø)
components/gitpod-cli/cmd/await-port.go 7.14% <0.00%> (ø)
components/gitpod-cli/cmd/forward-port.go 5.45% <0.00%> (ø)
components/gitpod-cli/cmd/init.go 1.86% <0.00%> (ø)
components/gitpod-cli/cmd/git-token-validator.go 13.20% <0.00%> (ø)
components/gitpod-cli/cmd/preview.go 32.14% <0.00%> (ø)
components/gitpod-cli/cmd/credential-helper.go 1.26% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a5b02...aea98dd. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jun 12, 2021

Test:

Screenshot from 2021-06-12 18-29-16

Check in settings:

Screenshot from 2021-06-12 18-30-21

@JanKoehnlein JanKoehnlein self-requested a review June 14, 2021 12:42
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aledbf aledbf merged commit eeb4a39 into main Jun 14, 2021
@aledbf aledbf deleted the aledbf/gpenv branch June 14, 2021 15:28
@shaal
Copy link
Contributor

shaal commented Jun 14, 2021

@aledbf Thank you for fixing this so quickly!
Do you know when will this fix be deployed to gitpod.io ?

@aledbf
Copy link
Member Author

aledbf commented Jun 14, 2021

@csweichel @meysholdt 👆

@csweichel
Copy link
Contributor

Up to @meysholdt ... Considering current deployment efforts I'd reckon we'd want to batch this change with others. But that's Mo's call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gp env fails when the content contains the character =
4 participants