[supervisor] fix caching Not Found as OTS token #4577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Gitpod Server OTS token expires after some time. If the workspace startup takes a while for some reasons then the supervisor gets Not Found, but since it does not check http status code it cached Not Found as a token. Triggering all kind of frontend issues consequently:
How to test
Not sure. Expiration time is quite high, I don't understand how supervisor manages to miss the token.