Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell "instance" correctly. #4722

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

mikenikles
Copy link
Contributor

Close #4720.

@mikenikles mikenikles requested review from a team, JanKoehnlein and akosyakov and removed request for a team July 6, 2021 23:01
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #4722 (43e38d8) into main (5c5456d) will increase coverage by 36.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4722       +/-   ##
=========================================
+ Coverage      0   36.38%   +36.38%     
=========================================
  Files         0       14       +14     
  Lines         0     3881     +3881     
=========================================
+ Hits          0     1412     +1412     
- Misses        0     2349     +2349     
- Partials      0      120      +120     
Flag Coverage Δ
components-ws-manager-app 36.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/status.go 72.32% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.26% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 66.66% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/config.go 32.50% <0.00%> (ø)
...-manager/pkg/manager/internal/workpool/workpool.go 100.00% <0.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager_ee.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 25.87% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 78.53% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5456d...43e38d8. Read the comment docs.

Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csweichel csweichel merged commit 334c135 into main Jul 8, 2021
@csweichel csweichel deleted the mikenikles/fix-a-spelling-mistake-4720 branch July 8, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix a spelling mistake
3 participants