[werft] Add sweeper cleanup logic for k3s ws cluster #4746
Conversation
princerachit
force-pushed
the
prs/sweeper-n-meta-ws-disable
branch
from
cba6362 to
60412e9
Compare
princerachit
changed the title
.werft/wipe-devstaging.ts
Outdated
|
|
||
|
|
||
| async function wipeDevstaging() { | ||
| async function wipeDevstaging(pathToKubeConfig: string) { |
There was a problem hiding this comment.
I won't find time for a full review today, but: please let's try to find another way to switch between kubectl contexts. This really decreases the signal to noise ratio a lot.
I have not coherent view on this or what might be better, but will try to come up with sth tomorrow.
There was a problem hiding this comment.
One way I can think of is to merge all the kubeconfigs we have into the default one and then use context switch. That would involve downloading a kubeconfig -> updating the context name in that and then adding it to the default kubeconfig.
Since pathToKubeConfig is how I have done for all other places I would let this PR merge and raise a separate PR to use a new approach for all the files.
There was a problem hiding this comment.
Since pathToKubeConfig is how I have done for all other places I would let this PR merge and raise a separate PR to use a new approach for all the files.
Ok, don't want to block this PR as it fixes sweeper. But let's not forget this.
One way I can think of is to merge all the kubeconfigs we have into the default one and then use context switch.
This was the way we used to do it in the past albeit it was simpler back then because clusters were static. But we can also leave the separate kubectl configs, but pass a more generic env around which exec supports (we already have that in some places).
There was a problem hiding this comment.
This was the way we used to do it in the past albeit it was simpler back then because clusters were static. But we can also leave the separate kubectl configs, but pass a more generic env around which exec supports (we already have that in some places).
This seems like a much better solution! I will try this out and raise a PR
|
/werft run 👍 started the job as gitpod-build-prs-sweeper-n-meta-ws-disable.3 |
.werft/wipe-devstaging.ts
Outdated
| async function deleteExternalIp(k3sWsProxyIP: string, namespace: string) { |
There was a problem hiding this comment.
Note: In general it would be good to find a common place for code like this, like a k3s-cluster.ts or deployment.ts or so. wipe-staging.ts should be just calling that stuff.
There was a problem hiding this comment.
makes sense. Let me move this to another file.
|
/werft run 👍 started the job as gitpod-build-prs-sweeper-n-meta-ws-disable.7 |
|
/werft run 👍 started the job as gitpod-build-prs-sweeper-n-meta-ws-disable.8 |
princerachit
force-pushed
the
prs/sweeper-n-meta-ws-disable
branch
from
58d69da to
73c5811
Compare
|
/werft run 👍 started the job as gitpod-build-prs-sweeper-n-meta-ws-disable.10 |
* Update sweeper logic to delete k3s ws preview env and refactor methods and files
What?
When running wipe job do the following:
Testing
To test this out I manually edited the sweeper deploy and added arg
--timeout=5mto trigger wipe job instantly. The cleanup succeededReference job in a different branch