[local-companion-app] Fix ssh_config generation on Windows #4774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4768
This PR fixes the
ssh_config
file generation on Windows by introducing a more sensible default to the--ssh-config
flag. Instead of hardcoding/tmp
it defaults toos.TmpDir()
if theGOOS == "windows"
.fixes #4759
In addition, this PR introduces fresh SSH keypair generation for each workspace. This way we don't rely on the user having a keypair generated already, and don't spread the user's
id_rsa.pub
content around. Also, the SSH public key upload is now properly synchronised (before it was justtime.Sleep(500 * time.Millisecond)
).How to test