[gpctl] Talk to ws-manager hosts directly #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
requested review from
a team,
rl-gitpod and
princerachit
and removed request for
a team
| secopt := grpc.WithInsecure() | ||
| if certFromSecret, _ := workspacesCmd.Flags().GetBool("tls-from-secret"); certFromSecret { | ||
| certPool, err := util.CertPoolFromSecret(clientSet, namespace, "ws-manager-tls", []string{"ca.crt"}) | ||
| if fn, _ := workspacesCmd.Flags().GetString("tls-path"); fn != "" { |
There was a problem hiding this comment.
nit: having this as another function will reduce loc in this funtion.
There was a problem hiding this comment.
It would indeed. We've reached a point where we should pull something like this into common-go anyways
princerachit
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
gpctl workspacesto talk to a ws-manager host directly without assuming a correct kubeconfig.