Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chart] Add default resource request for MySQL #4795

Merged
merged 1 commit into from
Jul 13, 2021
Merged

[chart] Add default resource request for MySQL #4795

merged 1 commit into from
Jul 13, 2021

Conversation

csweichel
Copy link
Contributor

fixes #4791

@csweichel csweichel requested a review from geropl July 13, 2021 10:28
@csweichel csweichel requested a review from a team as a code owner July 13, 2021 10:28
@csweichel csweichel removed the request for review from a team July 13, 2021 10:28
geropl
geropl reviewed Jul 13, 2021
View reviewed changes
chart/values.yaml
resources:
requests:
cpu: 200m
memory: 250Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd vote for:

  • no CPU
  • memory aroung 100Mi
    to not clutter core-dev. But let's try this first.

geropl
geropl approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csweichel csweichel merged commit d2a830d into main Jul 13, 2021
@csweichel csweichel deleted the csweichel/mysql-does-not-come-up-4791 branch July 13, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql does not come up bc of missing resource requests
2 participants
@csweichel @geropl