Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-service] Improve CPU utilization for initial git clone command #4847

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 16, 2021

No description provided.

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat requested a review from akosyakov July 16, 2021 14:35
@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/hold

@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #4847 (92553f5) into main (ae57b04) will increase coverage by 32.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4847       +/-   ##
=========================================
+ Coverage      0   32.62%   +32.62%     
=========================================
  Files         0       69       +69     
  Lines         0    13739    +13739     
=========================================
+ Hits          0     4482     +4482     
- Misses        0     8842     +8842     
- Partials      0      415      +415     
Flag Coverage Δ
components-content-service-app 14.46% <100.00%> (?)
components-content-service-lib 14.46% <100.00%> (?)
components-image-builder-app 34.44% <ø> (?)
components-supervisor-app 35.94% <ø> (?)
components-ws-daemon-app 22.29% <ø> (?)
components-ws-manager-app 36.77% <ø> (?)
components-ws-proxy-app 67.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/content-service/pkg/git/git.go 37.71% <100.00%> (ø)
...-manager/pkg/manager/internal/workpool/workpool.go 100.00% <0.00%> (ø)
components/supervisor/pkg/ports/ports.go 58.62% <0.00%> (ø)
components/ws-manager/pkg/manager/manager_ee.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/quota/mounts.go 53.19% <0.00%> (ø)
...onents/content-service/pkg/service/blob-service.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/routes.go 83.47% <0.00%> (ø)
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
components/content-service/pkg/archive/tar.go 60.31% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go 25.50% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae57b04...92553f5. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Jul 16, 2021
@csweichel
Copy link
Contributor

/hold cancel

@roboquat roboquat merged commit 7de657c into main Jul 16, 2021
@roboquat roboquat deleted the aledbf/gitclone branch July 16, 2021 15:00
@ArthurSens
Copy link
Contributor

ArthurSens commented Jul 16, 2021

Can't wait to see the results after deploying to prod next Tuesday 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants