Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manmager] Remove span logs from WorkspaceReadyProbe #4883

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[ws-manmager] Remove span logs from WorkspaceReadyProbe #4883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions components/ws-manager/pkg/manager/probe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,25 +78,21 @@ func (p *WorkspaceReadyProbe) Run(ctx context.Context) WorkspaceProbeResult {
return WorkspaceProbeStopped
}

span.LogKV("event", "probe start")
resp, err := client.Get(p.readyURL)
if err != nil {
urlerr, ok := err.(*url.Error)
if !ok || !urlerr.Timeout() {
span.LogKV("response", "error")
log.WithError(err).Debug("got a non-timeout error during workspace probe")
time.Sleep(p.RetryDelay)
continue
}

// we've timed out - do not log this as it would spam the logs for no good reason
span.LogKV("response", "timeout")
continue
}
resp.Body.Close()

if resp.StatusCode != http.StatusOK {
span.LogKV("response", resp.StatusCode)
log.WithField("url", p.readyURL).WithField("status", resp.StatusCode).Debug("workspace did not respond to ready probe with OK status")
time.Sleep(p.RetryDelay)
continue
Expand Down