-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard/code] Produce timing data for workspace startup #4907
Conversation
010180b
to
6a09826
Compare
/hold @akosyakov I want to make sure you get a chance to have a look at this change. Hence I'm holding the merge. |
Usually yes, but we did not merge yet #4807 which points to gp-code. Main state sits in https://github.com/gitpod-io/vscode/tree/gp-code-1.57.1 Updated It was merged, but please see comments below. |
I think you can do it in the supervisor instead of VS Code:
If ideService.state is ready, it means that IDE was rendered. |
Could we also capture a reason why starting IDE failed? There is another state on ideServices.failureCause, at least it should work if there are not any uncaptured async errors. |
/werft run 👍 started the job as gitpod-build-csweichel-enhancement-more-insight-4863.3 |
@akosyakov thank you for the feedback. I'll move the write to the supervisor frontend, and also capture the failure reason. |
6a09826
to
6bbf476
Compare
properties: { | ||
workspaceId: gitpodServiceClient.info.latestInstance?.workspaceId, | ||
phase: `ide-${ideService.state}`, | ||
error: ideService.failureCause?.message, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is also can be ideService.failureCause?.stack
it would be interesting to capture it
/werft run 👍 started the job as gitpod-build-csweichel-enhancement-more-insight-4863.5 |
/hold cancel |
LGTM label has been added. Git tree hash: 080c71bce25fb16fe4695f25f9864f048b1fe5c2
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev, csweichel, jakobhero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR produces analytics events from the frontend to track the speed and reliability of workspace starts. E.g.
Corresponding code PR: gitpod-io/openvscode-server#21
@akosyakov what's the usual path here? Merge the PR in vscode and then update the commit in this one?
Caveat: we'll possibly receive multiple
vsc_opened
events, namely whenever the user opens the IDE, e.g. reloads the window or opens another one.fixes #4863
/werft analytics=log