Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "DO NOT MERGE THIS" #4957

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Revert "DO NOT MERGE THIS" #4957

merged 1 commit into from
Jul 26, 2021

Conversation

AlexTugarev
Copy link
Member

This PR reverts an unwanted change from #4876

@AlexTugarev
Revert "DO NOT MERGE THIS"
b0a7ecc 
This reverts commit 2114062.
jankeromnes
jankeromnes approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@roboquat roboquat added the lgtm label Jul 26, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: a69d3d1f99659a00266fefde1b0c852eeaa384ac

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, jankeromnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jankeromnes
Copy link
Contributor

jankeromnes commented Jul 26, 2021 •
edited by werft-gitpod-dev-com bot
Loading 

  1) AccountServiceSpec
       testRemainingHoursUnlimited:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/tmp/build/components-ee-payment-endpoint--dbtest.9bdaf3507987f4b895fc7e43cefa425973a931c8/src/accounting/account-service.spec.db.ts)

Random test timeout / needs an increased timeout.

/werft run

👍 started the job as gitpod-build-at-revert.1

@roboquat roboquat merged commit 9b9f3d7 into main Jul 26, 2021
@roboquat roboquat deleted the at/revert branch July 26, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes jankeromnes approved these changes

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

Assignees

@jankeromnes jankeromnes

Labels
approved size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexTugarev @roboquat @jankeromnes