-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-daemon] Remove old sandboxing behaviour #4994
Conversation
dc8b7c0
to
0f19525
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel Associated issue: #4993 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 55c2db6b078e74437d8a02bf15f1bc1ce4af4879
|
Codecov Report
@@ Coverage Diff @@
## main #4994 +/- ##
=========================================
+ Coverage 0 22.99% +22.99%
=========================================
Files 0 11 +11
Lines 0 1918 +1918
=========================================
+ Hits 0 441 +441
- Misses 0 1418 +1418
- Partials 0 59 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fixes #4993
We used to have some means to limit the size of a workspace by placing its content in a loopback-mounted file. This mechanism never worked well and we haven't enabled it in about a year's time. Now, with recent harmonisation on the config surface (#4969) we inadvertently re-enabled this old behaviour.
This PR does away with this broken "sandbox" mechanism.