Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Don't nil-deref on timeout computation #5013

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

csweichel
Copy link
Contributor

fixes #5011

@roboquat roboquat requested a review from rl-gitpod July 29, 2021 15:25
@csweichel csweichel requested review from aledbf and removed request for rl-gitpod July 29, 2021 15:25
@aledbf
Copy link
Member

aledbf commented Jul 29, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6390f5e17e10c24f408bc8703ec9a8f21b372830

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #5011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #5013 (22d65fe) into main (4c70e7a) will increase coverage by 36.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5013       +/-   ##
=========================================
+ Coverage      0   36.32%   +36.32%     
=========================================
  Files         0       13       +13     
  Lines         0     3749     +3749     
=========================================
+ Hits          0     1362     +1362     
- Misses        0     2272     +2272     
- Partials      0      115      +115     
Flag Coverage Δ
components-ws-manager-app 36.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/status.go 71.96% <0.00%> (ø)
components/ws-manager/pkg/manager/config.go 32.50% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go 0.00% <0.00%> (ø)
...-manager/pkg/manager/internal/workpool/workpool.go 100.00% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go 74.46% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 24.89% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 78.79% <0.00%> (ø)
components/ws-manager/pkg/manager/monitor.go 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c70e7a...22d65fe. Read the comment docs.

@roboquat roboquat merged commit a32b5c0 into main Jul 29, 2021
@roboquat roboquat deleted the csweichel/ws-manager-nil-deref-5011 branch July 29, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-manager] nil deref in IsWorkspaceTimedOut
3 participants