fix(workspace): force-stop workspaces stuck in a bad state #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
fix/5016-force-stop
branch
4 times, most recently
from
1480a29 to
a88243b
Compare
mrsimonemms
commented
Aug 6, 2021
| const preparingKillTime = creationTime + (this.config.timeouts.preparingPhaseSeconds * 1000); | ||
| const unknownKillTime = creationTime + (this.config.timeouts.unknownPhaseSeconds * 1000); | ||
| const exceededPreparingTime = Date.now() >= preparingKillTime; | ||
| const exceededUnknown = Date.now() >= unknownKillTime; |
mrsimonemms
commented
Aug 6, 2021
mrsimonemms
commented
Aug 6, 2021
mrsimonemms
force-pushed
the
fix/5016-force-stop
branch
from
a88243b to
1e234b3
Compare
mrsimonemms
force-pushed
the
fix/5016-force-stop
branch
3 times, most recently
from
3cf2ecd to
2f8b04f
Compare
csweichel
reviewed
Aug 6, 2021
mrsimonemms
force-pushed
the
fix/5016-force-stop
branch
from
2f8b04f to
c00a164
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6959bff2c7695c390cf3398e182c7a60daf3ce9e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #5016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5016
This was tested by scaling the ws-manager to 0 (
kubectl scale deployment --replicas=0 ws-manager) and then creating a new workspace. After the elapsed time (suggest editing the ConfigMap so not waiting 2 hours) when failing to start the workspace you'll see something like this:Things to note:
setIntervaldoes not kill any previous runs. There are 60 seconds between runs which SHOULD be enough, but this may need adjustingsetIntervalare logged. Suggest adding an alert (or at least adding to Prometheus)Future improvements:
Happy to demo to anyone who wants to see it, and to check it meets the needs of the ticket