Skip to content

Add What's New entry for teams and projects #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add What's New entry for teams and projects #5126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
070219e
Add entry for teams and projects
gtsiolis Aug 9, 2021
85e217d
Add link to feedback issue
gtsiolis Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions components/dashboard/src/whatsnew/WhatsNew-2021-08.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/**
* Copyright (c) 2021 Gitpod GmbH. All rights reserved.
* Licensed under the GNU Affero General Public License (AGPL).
* See License-AGPL.txt in the project root for license information.
*/

import { User } from "@gitpod/gitpod-protocol";
import { WhatsNewEntry } from "./WhatsNew";
import { switchToVSCodeAction } from "./WhatsNew-2021-04";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I have no idea if this is needed. 😅

import PillLabel from "../components/PillLabel";

export const WhatsNewEntry202108: WhatsNewEntry = {
children: (user: User, setUser: React.Dispatch<User>) => {

return <>
<div className="border-t border-b border-gray-200 dark:border-gray-800 -mx-6 px-6 pt-6 pb-4">
<p className="pb-2 text-gray-900 dark:text-gray-100 text-base font-medium">Teams & Projects <PillLabel>New Feature</PillLabel></p>
<p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. 🎉</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts:

  • "Hey!" is quite strong, maybe "Hi there!" is more cheerful and less "shouty"?
  • All teams will be migrated "in the coming weeks" creates the wrong idea that this will happen very fast, and raises too many scary questions about billing etc. Probably safer to say the existing teams remain unchanged for now / might get migrated later "in due time"

Suggestion that you can apply in one click on GitHub:

Suggested change
<p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. 🎉</p>
<p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hi there! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. Existing team plans remain unchanged. No action is required on your side. 🎉</p>

<p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">You can create as many teams as you need and import repositories as projects from the top navigation. 💡</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do our users really "need" a feature that hasn't existed until now? Maybe "want" is better.
  • "repositories as projects" sounds a bit too complicated. Maybe just "projects"?
Suggested change
<p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">You can create as many teams as you need and import repositories as projects from the top navigation. 💡</p>
<p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">You can create as many teams as you want and import projects from the top navigation. 💡</p>

<p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">We welcome any input on this first iteration in <a href="https://github.com/gitpod-io/gitpod/issues/5095" className="learn-more">the feedback issue</a>. 📝</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also link to the (upcoming) blog post to learn more, and add a screenshot e.g. like this one on Slack (internal)?

</div>
</>;
},
newsKey: 'August-2021',
maxUserCreationDate: '2021-08-17',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Not sure what this does but I've added the target deployment date of next Tuesday (17.08.2021). 🐼

actionAfterSeen: switchToVSCodeAction,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this (this switches users from Theia to VSCode when they accept the Modal -- this is not relevant here)

};
2 changes: 2 additions & 0 deletions components/dashboard/src/whatsnew/WhatsNew.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ import { User } from "@gitpod/gitpod-protocol";
import Modal from "../components/Modal";
import { WhatsNewEntry202104 } from "./WhatsNew-2021-04";
import { WhatsNewEntry202106 } from "./WhatsNew-2021-06";
import { WhatsNewEntry202108 } from "./WhatsNew-2021-08";
import { UserContext } from "../user-context";
import { useContext, useState } from "react";
import { getGitpodService } from "../service/service";

const allEntries: WhatsNewEntry[] = [
WhatsNewEntry202106,
WhatsNewEntry202104,
WhatsNewEntry202108
]

export const shouldSeeWhatsNew = (user: User, news: { newsKey: string, maxUserCreationDate: string }[] = allEntries) => {
Expand Down