Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Add support for typescript map #5127

Merged
merged 1 commit into from
Aug 11, 2021
Merged

[server] Add support for typescript map #5127

merged 1 commit into from
Aug 11, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 9, 2021

In case of errors, the stack trace reports the line of the compiled javascript file instead of the typescript one.
https://www.npmjs.com/package/source-map-support

@roboquat roboquat requested a review from laushinka August 9, 2021 20:40
@aledbf
Copy link
Member Author

aledbf commented Aug 9, 2021

/assign @csweichel

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 10, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17a7de278ad827e4614c7518360a66473c1d0555

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit e7f9a1f into main Aug 11, 2021
@roboquat roboquat deleted the aledbf/tsmap branch August 11, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants