Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not upload ghost workspace logs and skip backups #5161

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 12, 2021

no remote storage configured:
    github.com/gitpod-io/gitpod/ws-daemon/pkg/content.(*WorkspaceService).uploadWorkspaceLogs
        github.com/gitpod-io/gitpod/ws-daemon/pkg/content/service.go:552"

Internal log https://cloudlogging.app.goo.gl/2ty2pZsFRfVtLARx6

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/assign @csweichel

@aledbf aledbf changed the title Do not upload ghost workspace logs Do not upload ghost workspace logs and skip backups Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #5161 (3174a5b) into main (8f867ae) will increase coverage by 16.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5161       +/-   ##
===========================================
+ Coverage   19.44%   36.32%   +16.87%     
===========================================
  Files          14       13        -1     
  Lines        2510     3750     +1240     
===========================================
+ Hits          488     1362      +874     
- Misses       1960     2273      +313     
- Partials       62      115       +53     
Flag Coverage Δ
components-workspacekit-app ?
components-ws-daemon-app ?
components-ws-manager-app 36.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/monitor.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go
components/ws-daemon/pkg/resources/dispatch.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/content/initializer.go
components/ws-daemon/pkg/content/archive.go
components/ws-daemon/pkg/resources/controller.go
components/workspacekit/cmd/lift.go
components/ws-daemon/pkg/content/tar.go
components/ws-daemon/pkg/content/config.go
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f867ae...3174a5b. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 12, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 400f78cbdc4f8749d87befb796f9ad2cbba7ce7c

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 59ba5ee into main Aug 12, 2021
@roboquat roboquat deleted the aledbf/ghostl branch August 12, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants