-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blobserve] Catch panic in HTTP requests #5241
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5241 +/- ##
=========================================
+ Coverage 0 28.17% +28.17%
=========================================
Files 0 3 +3
Lines 0 536 +536
=========================================
+ Hits 0 151 +151
- Misses 0 368 +368
- Partials 0 17 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9c7e551
to
09f8687
Compare
@JanKoehnlein Here is the solution we discussed. WDYT? |
/lgtm |
LGTM label has been added. Git tree hash: d3ee459491c9b2f5614a143bb49b35f17d4f6934
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, JanKoehnlein Associated issue: #5232 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We get some panic errors in blobserve from time to time. However, the log messages from net/http are not very helpful (see #5232).
This change catches the panic errors and adds proper logs like this:
(here tested with this temp. change: 9c7e551)
Hopefully, this change will help to find the proper segment fault.