Laushinka/let people unsubscribe 4761 #5281
Conversation
laushinka
force-pushed
the
laushinka/let-people-unsubscribe-4761
branch
from
d4d51e3 to
fa1448d
Compare
|
Product question: Should this be an Enterprise Edition feature? |
Who should answer this? |
|
| Who should answer this? |
laushinka
force-pushed
the
laushinka/let-people-unsubscribe-4761
branch
from
c383328 to
0ab0839
Compare
| } | ||
| } | ||
| }); | ||
| this.analytics.track({ |
There was a problem hiding this comment.
Let's also change this to an identify call in order to be consistent with what 1) we are doing in the else branch of the conditional and 2) customer.io / other 3rd party software is expecting downstream (see here).
| get apiRouter(): express.Router { | ||
| const router = express.Router(); | ||
|
|
||
| router.get("/unsubscribe", async (req: express.Request, res: express.Response) => { |
There was a problem hiding this comment.
we would like to use this API to subscribe newsletter users so that they are automatically attached to their user accounts if a the email for the newsletter signup matches any user's primary email. is it ok for you to extend the scope of this PR to include a /subscribe endpoint that signs up a known or unknown user for a specified subscription list?
There was a problem hiding this comment.
I would prefer to keep the existing scope of this ticket for reasons of: 1) planning and 2) transparency :) When tickets are approved and put to in progress, I assume there are already plans and estimations of how much effort the current ticket/board would take. Changing the scope might change the planning for the rest of the board. Secondly, a changing scope almost at the end of the work might not be known to the stakeholders of the board.
However, I am still learning how the team usually manages their projects so I will tag @JanKoehnlein here for his thoughts.
There was a problem hiding this comment.
Let's open another ticket for @jakobhero's request. I feel like it has to be discussed in terms of security and GDPR as well.
laushinka
force-pushed
the
laushinka/let-people-unsubscribe-4761
branch
from
0ab0839 to
5e06952
Compare
It can stay in the open-source code base. We would only consider code that adds useful enterprise features to be moved to an enterprise-licensed directory, everything else goes open-source. |
| get apiRouter(): express.Router { | ||
| const router = express.Router(); | ||
|
|
||
| router.get("/unsubscribe", async (req: express.Request, res: express.Response) => { |
There was a problem hiding this comment.
Let's open another ticket for @jakobhero's request. I feel like it has to be discussed in terms of security and GDPR as well.
|
LGTM label has been added. Git tree hash: fb94e55211835b3e7496627d88980e9742c4542a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JanKoehnlein Associated issue: #4761 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR created initially to run the following command and test that the new events are reflected on Segment.
/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe
Fixes #4761