Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] remove failed backups #5325

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

svenefftinge
Copy link
Member

When a backup failed (mostly due to hitting the size limit)
the tar file hangs around on the node without clean up.

fixes #5324

When a backup failed (mostly due to hitting the size limit)
the tar file hangs around on the node without clean up.

fixes #5324
@roboquat roboquat requested a review from aledbf August 23, 2021 13:23
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #5325 (6e3f74e) into main (a169bc0) will increase coverage by 23.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5325       +/-   ##
=========================================
+ Coverage      0   23.21%   +23.21%     
=========================================
  Files         0       11       +11     
  Lines         0     1930     +1930     
=========================================
+ Hits          0      448      +448     
- Misses        0     1423     +1423     
- Partials      0       59       +59     
Flag Coverage Δ
components-ws-daemon-app 23.21% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/content/archive.go 59.34% <100.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 46.71% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/resources/controller.go 33.69% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a169bc0...6e3f74e. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 23, 2021

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 25287e34a0703f9fe4db514567299023b3a807c5

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #5324

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-daemon] Clean up failed backups
3 participants