Add support link to the dashboard #5399
Conversation
gtsiolis
requested review from
svenefftinge
and removed request for
AlexTugarev
|
@svenefftinge what do you think? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Re-opening as this is still relevant. |
|
@jankeromnes what do you think of this minor change? We could go get data first but I think it's safe to assume these links are not widely used. In the long run having a dedicated help menu could be the best way forward. Looking for a way to surface the awesome work from gitpod-io/website#862. 🌟 |
gtsiolis
requested review from
jankeromnes
and removed request for
svenefftinge
gtsiolis
force-pushed
the
gt/add-support-link
branch
from
f91482d to
57083df
Compare
There was a problem hiding this comment.
Ah, I just noticed this PR thanks to your nudge to check https://github.com/pulls/review-requested 🙈 -- sorry that reviewing this took so long that you had to fight off stale-bot! 😬
This change seems like an excellent idea to me! Especially since /support links to Community but also to other places, and looks generally very helpful. ✨
Holding due to a minor suggestion in-line, but please feel free to unblock at any time! 🚀
/hold
components/dashboard/src/Menu.tsx
Outdated
| @@ -167,8 +167,8 @@ export default function Menu() { | |||
| link: 'https://www.gitpod.io/docs/', | |||
| }, | |||
| { | |||
| title: 'Community', | |||
| link: 'https://community.gitpod.io/', | |||
| title: 'Support', | |||
There was a problem hiding this comment.
Optional suggestion: I find the word "Support" a bit ambiguous here (it sounds a bit like "Give us Money" 😅) -- what do you think of calling this "Help"? (Also saves a few characters 😇)
| title: 'Support', | |
| title: 'Help', |
There was a problem hiding this comment.
DOES. THE. JOB. I think both options could suffice so let's go with your suggestion and iterate later if needed.
|
LGTM label has been added. Git tree hash: 57a66cde38f1f975ac7d438b2c1d304f9cee3f99
|
|
/werft run 👍 started the job as gitpod-build-gt-add-support-link.4 |
|
New changes are detected. LGTM label has been removed. |
Co-authored-by: George Tsiolis <tsiolis.g@gmail.com> Co-authored-by: Jan Keromnes <jan.keromnes@typefox.io>
gtsiolis
force-pushed
the
gt/add-support-link
branch
from
0305e6f to
52233be
Compare
|
Carrying |
|
/approve |
|
@gtsiolis: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gtsiolis, jankeromnes No associated issue. Requirement bypassed by manually added approval. The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat
added
deployed: webapp
What does this PR do?
Replace the Community link on the top right menu with a link to the new Support page added in https://github.com/gitpod-io/website/pull/862.