Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-smith] Improve report of infringements with long commands #5415

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 27, 2021

No description provided.

@roboquat roboquat requested a review from rl-gitpod August 27, 2021 10:37
@aledbf
Copy link
Member Author

aledbf commented Aug 27, 2021

/assign @jankeromnes

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #5415 (eaf13c3) into main (8aab84e) will increase coverage by 25.82%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5415       +/-   ##
=========================================
+ Coverage      0   25.82%   +25.82%     
=========================================
  Files         0        5        +5     
  Lines         0      790      +790     
=========================================
+ Hits          0      204      +204     
- Misses        0      563      +563     
- Partials      0       23       +23     
Flag Coverage Δ
components-ee-agent-smith-app 25.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ee/agent-smith/pkg/agent/agent.go 18.72% <0.00%> (ø)
...omponents/ee/agent-smith/pkg/signature/sinature.go 44.27% <0.00%> (ø)
components/ee/agent-smith/pkg/agent/actions.go 0.00% <0.00%> (ø)
components/ee/agent-smith/pkg/agent/egress.go 0.00% <0.00%> (ø)
components/ee/agent-smith/pkg/agent/metrics.go 61.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aab84e...eaf13c3. Read the comment docs.

@jankeromnes jankeromnes changed the title [agent-smioth] Improve report of infringements with long commands [agent-smith] Improve report of infringements with long commands Aug 27, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 27, 2021

Many thanks @aledbf!

For the review, I'll defer to @csweichel and/or @leodido 🙏

FYI, this is done to fix the very long messages posted to Slack (internal): https://gitpod.slack.com/archives/C01TFSMBYQ6/p1630002484003700

@jankeromnes jankeromnes assigned leodido and csweichel and unassigned jankeromnes Aug 27, 2021
@jankeromnes jankeromnes requested review from csweichel and leodido and removed request for rl-gitpod August 27, 2021 12:48
Copy link
Contributor

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat roboquat added the lgtm label Aug 27, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: a1d2517b54e35966e18b32299ddb29c78f871f45

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, leodido

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a35798c into main Aug 30, 2021
@roboquat roboquat deleted the aledbf/longi branch August 30, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants