Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed nodeAffinity for preview environments #5432

Merged
merged 1 commit into from
Aug 31, 2021
Merged

changed nodeAffinity for preview environments #5432

merged 1 commit into from
Aug 31, 2021

Conversation

fullmetalrooster
Copy link
Contributor

@fullmetalrooster fullmetalrooster commented Aug 30, 2021 •
edited
Loading

This PR should move the preview environments to new clusters which are split into meta and workspace nodepools. This should reduce the overload the current workload nodepool. All nodeaffinities have been moved to a sepeate file. This will be used later to add new nodepools. There will be a file for every set of nodepools and a file will be choosen randomly.

@roboquat roboquat requested a review from jankeromnes August 30, 2021 05:53
@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 30, 2021 •
edited
Loading

Thanks! 🎉

It seems that the review request to me was unintentional. So, removing, but please feel free to re-add it again if you're expecting a review from me.

Tip: If you add /uncc to your PR comment, @roboquat will not immediately flag random reviewers.

@jankeromnes jankeromnes removed their request for review August 30, 2021 07:49
geropl
geropl reviewed Aug 30, 2021
View reviewed changes
.werft/jaeger.yaml Outdated Show resolved Hide resolved
geropl
geropl reviewed Aug 30, 2021
View reviewed changes
.werft/build.ts Outdated Show resolved Hide resolved
geropl
geropl reviewed Aug 30, 2021
View reviewed changes
.werft/build.ts Outdated Show resolved Hide resolved
@geropl
Copy link
Member

geropl commented Aug 30, 2021

/hold

geropl
geropl approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach LGTM. Please have a quick look at the comments as well before /unhold.

@roboquat roboquat added the lgtm label Aug 30, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b611baafa89c9bb334b42dee6242f5b6c5e3940

@roboquat roboquat removed the lgtm label Aug 30, 2021
@geropl
Copy link
Member

geropl commented Aug 30, 2021

/lgtm

looks like roboquat requires a re-lgtm :-/ Thought I could unblock beforehand.

@roboquat roboquat added the lgtm label Aug 30, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0399a44d650277a474f8e4b8753707f3adaeba1

@fullmetalrooster
Copy link
Contributor Author

/unhold

@roboquat roboquat removed the lgtm label Aug 30, 2021
@fullmetalrooster fullmetalrooster force-pushed the wth/node-affinity branch 3 times, most recently from dfcc4fb to f3668dc Compare August 31, 2021 06:44
@fullmetalrooster fullmetalrooster force-pushed the wth/node-affinity branch 2 times, most recently from 7906df8 to a140bb2 Compare August 31, 2021 06:50
@geropl
Copy link
Member

geropl commented Aug 31, 2021

/lgtm

@roboquat roboquat added the lgtm label Aug 31, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 644a2562edd92aab05b5783525debf389e223e0a

@geropl
Copy link
Member

geropl commented Aug 31, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit ee92ed0 into main Aug 31, 2021
@roboquat roboquat deleted the wth/node-affinity branch August 31, 2021 07:22
@geropl geropl mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@princerachit princerachit Awaiting requested review from princerachit

Assignees

@geropl geropl

Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fullmetalrooster @jankeromnes @geropl @roboquat