-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Allow team members (and everyone in legacy mode) to access prebuilds #5433
Conversation
c5b6615
to
101034c
Compare
beee7e8
to
c6063c0
Compare
c6063c0
to
bb38a6b
Compare
bb38a6b
to
3d99d68
Compare
I'm refactoring the change to move the team member related access into its own resource guard. |
3d99d68
to
6cb5987
Compare
187327a
to
50922e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, thanks!
Left a few questions & suggestions in-line.
Haven't tested this yet (will do so now).
Tested, and I'm now able to see the logs of a team prebuild! 🎉 (Apparently still running after 2h 😅) However, I also uncovered two bugs, but they're likely unrelated to this PR:
However, authorizing with GitLab resolves this. We should probably handle these errors better (and show a "Authorize GitLab" button)
|
/hold because of the questions & suggestions /lgtm otherwise 🎉 |
/approve no-issue /lgtm |
LGTM label has been added. Git tree hash: 56addfaaaf6bcd7e716c9cf3df45bea588b386cc
|
50922e5
to
5b6fec8
Compare
/lgtm |
/lgtm |
@svenefftinge: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankeromnes, svenefftinge Associated issue: #5344 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Jan Keromnes <jan.keromnes@typefox.io>
/lgtm |
LGTM label has been added. Git tree hash: 939b1f9028f6093dfd4bec9b64780f5c83e2658d
|
This PR relaxes resource-access so that team members can access prebuild workspaces and workspaceinstances.
It also replaces the old access guard for headless logs that would use the git access in favor of user/team based check.
caveat: Old prebuilds that don't have a project associated, yet, are accessible from everyone (see).
fixes #5344