-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle reconnecting websocket cancel #5436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
@rl-gitpod Could you clean up commit to remove code which did not make it? then you can comment /unhold
and the PR will be merged
LGTM label has been added. Git tree hash: e0df5b99dc8ae92948ae756774a0841990a26255
|
Codecov Report
@@ Coverage Diff @@
## main #5436 +/- ##
==========================================
- Coverage 36.18% 31.61% -4.58%
==========================================
Files 18 35 +17
Lines 4563 5846 +1283
==========================================
+ Hits 1651 1848 +197
- Misses 2765 3849 +1084
- Partials 147 149 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
47cefd2
to
e1c1b58
Compare
@akosyakov - wasn't 100% sure what you were requesting but I squashed the commits & comments, which removed the lgtm /unhold |
/lgtm |
LGTM label has been added. Git tree hash: e0df5b99dc8ae92948ae756774a0841990a26255
|
/approve |
/assign @csweichel |
/werft run 👍 started the job as gitpod-build-rl-gitpod-lca-reconnect-4858.2 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, csweichel Associated issue: #4858 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4858
Pass in context to allow cancel to be handled and not stay in reconnection attempt loop.