-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Bump gitpod-yml-inferrer #5438
Conversation
TestsNextJSRepo: https://github.com/gitpod-io/template-nextjs Guessed: tasks:
- init: npm install && npm run build
command: npm run start Actual: tasks:
- name: Start development environment
init: npm install
command: npm run dev TypeScript Node.jsRepo: https://github.com/gitpod-io/template-typescript-node Guessed: tasks:
- init: npm install && npm run build
command: npm run start Actual: tasks:
- command: |
mongod
- init: |
npm install
npm run build
command: |
npm run start Python DjangoRepo: https://github.com/gitpod-io/template-python-django Guessed: (nothing) Actual: tasks:
- init: |
python -m pip install --upgrade pip
python -m pip install Django
python manage.py migrate
command: |
python manage.py runserver Python FlaskRepo: https://github.com/gitpod-io/template-python-flask Guessed: tasks:
- init: pip install . Actual: tasks:
- before: |
export FLASK_APP=flaskr
export FLASK_ENV=development
init: |
pip install -e .
flask init-db
command: |
flask run JavaRepo: https://github.com/gitpod-io/spring-petclinic Guessed: tasks:
- init: ./mvnw install -DskipTests=false Actual: tasks:
- init: ./mvnw package -DskipTests
command: java -jar target/*.jar GoRepo: https://github.com/gitpod-io/template-golang-cli Guessed: tasks:
- init: go get && go build ./... && go test ./...
command: go run Actual: tasks:
- init: |
go get github.com/spf13/cobra/cobra
go build
command: |
./mycli --help RustRepo: https://github.com/gitpod-io/template-rust-cli Guessed: tasks:
- init: cargo build
command: cargo watch -x run Actual: tasks:
- init: |
cargo build
command: |
cargo run Ruby on RailsRepo: https://github.com/gitpod-io/template-ruby-on-rails-postgres Guessed: tasks:
- init: yarn install && bin/setup
command: bin/rails server Actual: tasks:
- init: >
bundle install &&
yarn install &&
rake db:create
command: >
rails server -b 0.0.0.0 CRepo: https://github.com/gitpod-io/template-c Guessed: tasks:
- init: make Actual: tasks:
- init: |
make
command: |
make help C++Repo: https://github.com/gitpod-io/template-cpp Guessed: tasks:
- init: cmake . Actual: tasks:
- init: |
cd build && make
command: |
cd build; conan info . |
@svenefftinge does it still make sense that this is a separate repository? If not, could we fold it in to gitpod-io? |
@jankeromnes are those tests automated? |
No. We moved that out before we completely went open-source. |
Happy to inline the inferrer if you'd prefer that. 👍
No, they're very manual (i.e. fork the Gitpod example templates, delete Also, they're qualitative, thus hard to automate (test is "does this look correct & sufficiently similar to the existing setup, which is always more complicated with more bells & whistles"). |
Yes, this was on purpose. Ideally, the The goal was to nudge users into editing the Please let me know if you'd like this to be different. |
Ah ok, let's not put in such a stopper for users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM label has been added. Git tree hash: eae05dbc5af5ec2bff6b512aa4614b0a1a163fb6
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: svenefftinge No associated issue. Requirement bypassed by manually added approval. The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Diff: gitpod-io/gitpod-yml-inferrer@b442c1c...5df8b1a