Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] Remove unnecessary log about port already exposed #5505

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 2, 2021

@roboquat roboquat requested a review from jeanp413 September 2, 2021 13:12
@aledbf
Copy link
Member Author

aledbf commented Sep 2, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #5505 (cdcfc1a) into main (254e378) will increase coverage by 18.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5505       +/-   ##
===========================================
+ Coverage   19.39%   37.78%   +18.39%     
===========================================
  Files           2       16       +14     
  Lines         165     4107     +3942     
===========================================
+ Hits           32     1552     +1520     
- Misses        131     2430     +2299     
- Partials        2      125      +123     
Flag Coverage Δ
components-local-app-app-linux ?
components-local-app-app-windows ?
components-supervisor-app 37.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/ports/served-ports.go 77.02% <ø> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/supervisor/pkg/supervisor/user.go 33.12% <0.00%> (ø)
components/supervisor/pkg/ports/ports.go 61.79% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go 73.46% <0.00%> (ø)
components/supervisor/pkg/supervisor/tasks.go 55.22% <0.00%> (ø)
components/supervisor/pkg/supervisor/git.go 0.00% <0.00%> (ø)
components/supervisor/pkg/terminal/service.go 32.38% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254e378...cdcfc1a. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 3, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 3, 2021

LGTM label has been added.

Git tree hash: 779eb11564f5d7960d311cdd3188190ecdb27cb5

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit cbd0718 into main Sep 3, 2021
@roboquat roboquat deleted the aledbf/rp branch September 3, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants