-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dei): he -> [they|their] #5581
Conversation
ghuntley
commented
Sep 8, 2021
•
edited by csweichel
Loading
edited by csweichel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ghuntley! 🏀
We could probably remove the changed comment but there are a couple more which could be part of this PR. What do you think?
gitpod/components/ee/payment-endpoint/src/chargebee/subscription-mapper.ts
Lines 149 to 151 in f5f9926
* - Chargebee subscription cancelled: | |
* - terminate the Gitpod subscription to the end of current billing period because we want the user to retain the credits he already paid for | |
* We calculate it to one month after current billing period started because the Chargebee Subscription does not carry any information about this |
gitpod/components/ee/payment-endpoint/src/accounting/subscription-model.ts
Lines 97 to 100 in f5f9926
* Creates the following invariants on the given set of Subscriptions: | |
* - A user is granted a FREE subscription iff he has no paid subscription | |
* - For any given time from user.creationDate until forever the user has at least one subscription | |
* TODO Handle mis-use: Only grant a user FREE.hours par Month at most |
* A user may open private repos if he either: | ||
* - not started his free "priate repo trial" yet | ||
* - is has been no longer than 30 days since he started his "priate repo trial" | ||
* A user may open private repos if they either: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: We recently changed this to allow anyone to use private repos, see #5170. We could probably remove mayOpenPrivateRepo
and some of the functions below. Cc @svenefftinge
* A user may open private repos if he either: | ||
* - not started his free "priate repo trial" yet | ||
* - is has been no longer than 30 days since he started his "priate repo trial" | ||
* A user may open private repos if they either: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Much more inclusive!
/lgtm |
LGTM label has been added. Git tree hash: 2c725597e3ff1b70b278eb0d8b3db703556fcb56
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |