Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] Update code 1.60.0 #5633

Merged
merged 1 commit into from
Sep 14, 2021
Merged

[code] Update code 1.60.0 #5633

merged 1 commit into from
Sep 14, 2021

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Sep 9, 2021 •
edited by akosyakov
Loading

  • /werft with-clean-slate-deployment

Description

Update code to 1.60.0

Related Issue(s)

fix #5515, fix #5620

How to test

Release Notes

Update code to 1.60.0

@roboquat roboquat requested a review from csweichel September 9, 2021 15:58
@jeanp413 jeanp413 requested review from akosyakov and removed request for csweichel September 9, 2021 15:58
@akosyakov
Copy link
Member

@jeanp413 Could you have a look please? the build is failing

@jeanp413 jeanp413 force-pushed the jp/code-update-1.60.0 branch 2 times, most recently from 3843a03 to b7a9c0a Compare September 11, 2021 17:39
@jeanp413
Copy link
Member Author

jeanp413 commented Sep 13, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-code-update-1.60.0.8

@akosyakov
Copy link
Member

akosyakov commented Sep 13, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-code-update-1.60.0.9

@akosyakov
Copy link
Member

@jeanp413 I noticed that if I start https://jp-code-update-1.staging.gitpod-dev.com/#github.com/gitpod-io/gitpod then initial task terminals are not rendered properly in the bottom panel initially:
Screenshot 2021-09-13 at 12 26 33

Could you have a look how we can fix it? Maybe it is a bug in VS Code and we need upstream the fix?

Also terminals are not split for web target. It is ok for desktop, but web we need it to be split.

@akosyakov
Copy link
Member

Besides issues with terminals it looks very good.

@jeanp413
Copy link
Member Author

@akosyakov Fixed both issues in gitpod-io/openvscode-server@332c5fa and gitpod-io/openvscode-server@f8b5740

@akosyakov
Copy link
Member

akosyakov commented Sep 14, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-code-update-1.60.0.11

akosyakov
akosyakov approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

please clean up the history and /unhold, after that you can add lgtm label back via GitHub UI to trigger merge

@roboquat roboquat added the lgtm label Sep 14, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 040b61d8c4495c52fdc242278cd456b262772175

@akosyakov
Copy link
Member

akosyakov commented Sep 14, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-code-update-1.60.0.12

@jeanp413 jeanp413 force-pushed the jp/code-update-1.60.0 branch from cb32115 to 8e50da4 Compare September 14, 2021 14:50
@roboquat roboquat removed the lgtm label Sep 14, 2021
@jeanp413
Copy link
Member Author

/unhold

@jeanp413 jeanp413 marked this pull request as ready for review September 14, 2021 14:52
@akosyakov
Copy link
Member

/lgtm

@roboquat roboquat added the lgtm label Sep 14, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 040b61d8c4495c52fdc242278cd456b262772175

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue: #5515

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit cfb528c into main Sep 14, 2021
@roboquat roboquat deleted the jp/code-update-1.60.0 branch September 14, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees

@akosyakov akosyakov

Labels
approved release-note size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[code] streamline terminal integration Upgrade to VS Code 1.60.0
3 participants
@jeanp413 @akosyakov @roboquat